London| 26-ITP-May | Mandip Sanger | Sprint 3 | Alarm Clock - #1435
Open
mandipsanger wants to merge 6 commits into
Open
London| 26-ITP-May | Mandip Sanger | Sprint 3 | Alarm Clock#1435mandipsanger wants to merge 6 commits into
mandipsanger wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
mandipsanger
added
📅 Sprint 3
cjyuan
reviewed
Aug 14, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
You missed updating
index.htmlaccording to an instruction inreadme.md. -
Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Note: a user may not click the "Stop Alarm" button first before starting a new count down.
cjyuan
added
Reviewed
mandipsanger
added
Needs Review
cjyuan
reviewed
Aug 18, 2026
| <label for="alarmSet">Set time to:</label> | ||
| <input id="alarmSet" type="number" /> | ||
| <label for="alarmSet">Set time in seconds:</label> | ||
| <input id="alarmSet" type="number" min="1" step="1" placeholder="Enter seconds" /> |
Contributor
There was a problem hiding this comment.
Note: Without a form, the browser won't check the input against the constraints min="1" step="1".
Change is optional.
Comment on lines
+11
to
+20
| if (isNaN(numberValue)) { | ||
| alert("only enter a valid number."); | ||
| return; // exit a function if not a number | ||
| } | ||
|
|
||
| //step 3 validate if it is an integer | ||
| if (!Number.isInteger(numberValue)) { | ||
| alert("only enter an integer value."); | ||
| return; // exit a function if not an integer | ||
| } |
Contributor
There was a problem hiding this comment.
The integer check could also pick up NaN.
Comment on lines
+42
to
+44
| // Stop an existing timer | ||
| clearInterval(timer); | ||
|
|
Contributor
There was a problem hiding this comment.
- What else should also be reset?
Note: a user may not click the "Stop Alarm" button first before starting a new count down.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Sprint 3 AlarmClock